fix: uniform podcast player for all content types, hidden iframe for external audio
All checks were successful
Build & Deploy / build-and-deploy (push) Successful in 28s

This commit is contained in:
ordinarthur 2026-04-12 22:07:03 +02:00
parent d9e69aa76c
commit 96eff9433c
3 changed files with 93 additions and 110 deletions

View File

@ -1,82 +1,32 @@
import { useState } from 'react'
import { Play, Pause, Volume2, VolumeX, SkipBack, SkipForward, Maximize2, Minimize2 } from 'lucide-react'
import { Play, Pause, Volume2, VolumeX, SkipBack, SkipForward } from 'lucide-react'
import { usePlayerStore } from '@/stores/player'
import { formatDuration } from '@/lib/utils'
import { getEmbedInfo } from '@/lib/embed'
import { Avatar } from '@/components/ui/Avatar'
export function PlayerBar() {
const { current, isPlaying, isExternal, progress, duration, volume, toggle, seek, setVolume } = usePlayerStore()
const [expanded, setExpanded] = useState(false)
if (!current) return null
const embedInfo = isExternal ? getEmbedInfo(current.audio_url) : null
// External content: show expandable embed player
if (isExternal && embedInfo && isPlaying) {
return (
<div className={`fixed bottom-0 left-0 right-0 z-50 glass border-t border-border/60 shadow-[0_-4px_30px_rgba(30,27,51,0.08)] transition-all duration-300 ${expanded ? 'h-[70vh]' : 'h-[4.75rem]'}`}>
{expanded && (
<div className="w-full h-[calc(100%-4.75rem)] bg-black/95">
<iframe
src={embedInfo.embedUrl}
className="w-full h-full"
allow="autoplay; encrypted-media; picture-in-picture"
allowFullScreen
title={current.title}
/>
</div>
)}
<div className="max-w-6xl mx-auto px-4 sm:px-6 h-[4.75rem] flex items-center gap-4">
<div className="flex items-center gap-3 min-w-0 flex-1">
<div className="relative shrink-0">
{current.cover_url ? (
<img src={current.cover_url} alt="" className="w-11 h-11 rounded-xl object-cover shadow-organic-sm" />
) : (
<Avatar name={current.title} size="md" className="!rounded-xl" />
)}
<div className="absolute -bottom-0.5 -right-0.5 flex items-end gap-[2px] h-3 p-[2px] bg-surface rounded-md">
<div className="wave-bar" /><div className="wave-bar" /><div className="wave-bar" />
</div>
</div>
<div className="min-w-0">
<p className="text-[13px] font-semibold truncate">{current.title}</p>
<p className="text-[11px] text-text-secondary truncate">
{current.creator?.username} · via {embedInfo.platform === 'youtube' ? 'YouTube' : embedInfo.platform === 'dailymotion' ? 'Dailymotion' : 'SoundCloud'}
</p>
</div>
</div>
<button
onClick={() => setExpanded(!expanded)}
className="w-11 h-11 rounded-full bg-gradient-to-br from-primary to-[#7B6AEF] text-white flex items-center justify-center hover:shadow-[0_2px_20px_rgba(91,76,219,0.4)] transition-all active:scale-95 cursor-pointer"
>
{expanded ? <Minimize2 size={17} /> : <Maximize2 size={17} />}
</button>
</div>
</div>
)
}
// Native audio player
return (
<div className="fixed bottom-0 left-0 right-0 z-50 glass border-t border-border/60 shadow-[0_-4px_30px_rgba(30,27,51,0.08)]">
{/* Progress bar */}
<div className="relative h-[3px] bg-border-light cursor-pointer group" onClick={(e) => {
const rect = e.currentTarget.getBoundingClientRect()
const pct = (e.clientX - rect.left) / rect.width
seek(pct * duration)
}}>
<div
className="absolute inset-y-0 left-0 bg-gradient-to-r from-primary to-[#7B6AEF] transition-all rounded-full"
style={{ width: `${duration ? (progress / duration) * 100 : 0}%` }}
/>
<div
className="absolute top-1/2 -translate-y-1/2 w-3 h-3 rounded-full bg-primary shadow-[0_0_0_3px_rgba(91,76,219,0.2)] opacity-0 group-hover:opacity-100 transition-opacity"
style={{ left: `${duration ? (progress / duration) * 100 : 0}%`, marginLeft: '-6px' }}
/>
</div>
{/* Progress bar (native audio only) */}
{!isExternal && (
<div className="relative h-[3px] bg-border-light cursor-pointer group" onClick={(e) => {
const rect = e.currentTarget.getBoundingClientRect()
const pct = (e.clientX - rect.left) / rect.width
seek(pct * duration)
}}>
<div
className="absolute inset-y-0 left-0 bg-gradient-to-r from-primary to-[#7B6AEF] transition-all rounded-full"
style={{ width: `${duration ? (progress / duration) * 100 : 0}%` }}
/>
<div
className="absolute top-1/2 -translate-y-1/2 w-3 h-3 rounded-full bg-primary shadow-[0_0_0_3px_rgba(91,76,219,0.2)] opacity-0 group-hover:opacity-100 transition-opacity"
style={{ left: `${duration ? (progress / duration) * 100 : 0}%`, marginLeft: '-6px' }}
/>
</div>
)}
<div className="max-w-6xl mx-auto px-4 sm:px-6 h-[4.25rem] flex items-center gap-4">
{/* Track info */}
@ -101,37 +51,49 @@ export function PlayerBar() {
{/* Controls */}
<div className="flex items-center gap-2.5">
<button className="text-text-secondary hover:text-primary transition-colors cursor-pointer p-1" onClick={() => seek(Math.max(0, progress - 15))}>
<SkipBack size={17} />
</button>
{!isExternal && (
<button className="text-text-secondary hover:text-primary transition-colors cursor-pointer p-1" onClick={() => seek(Math.max(0, progress - 15))}>
<SkipBack size={17} />
</button>
)}
<button
onClick={toggle}
className="w-11 h-11 rounded-full bg-gradient-to-br from-primary to-[#7B6AEF] text-white flex items-center justify-center hover:shadow-[0_2px_20px_rgba(91,76,219,0.4)] transition-all active:scale-95 cursor-pointer"
>
{isPlaying ? <Pause size={17} /> : <Play size={17} className="ml-0.5" />}
</button>
<button className="text-text-secondary hover:text-primary transition-colors cursor-pointer p-1" onClick={() => seek(Math.min(duration, progress + 15))}>
<SkipForward size={17} />
</button>
{!isExternal && (
<button className="text-text-secondary hover:text-primary transition-colors cursor-pointer p-1" onClick={() => seek(Math.min(duration, progress + 15))}>
<SkipForward size={17} />
</button>
)}
</div>
{/* Volume & time */}
<div className="hidden sm:flex items-center gap-3 flex-1 justify-end">
<span className="text-[11px] text-text-secondary tabular-nums font-medium">
{formatDuration(progress)} / {formatDuration(duration)}
</span>
<button onClick={() => setVolume(volume === 0 ? 0.8 : 0)} className="text-text-secondary hover:text-primary transition-colors cursor-pointer">
{volume === 0 ? <VolumeX size={15} /> : <Volume2 size={15} />}
</button>
<input
type="range"
min={0}
max={1}
step={0.01}
value={volume}
onChange={(e) => setVolume(parseFloat(e.target.value))}
className="w-20"
/>
{!isExternal ? (
<>
<span className="text-[11px] text-text-secondary tabular-nums font-medium">
{formatDuration(progress)} / {formatDuration(duration)}
</span>
<button onClick={() => setVolume(volume === 0 ? 0.8 : 0)} className="text-text-secondary hover:text-primary transition-colors cursor-pointer">
{volume === 0 ? <VolumeX size={15} /> : <Volume2 size={15} />}
</button>
<input
type="range"
min={0}
max={1}
step={0.01}
value={volume}
onChange={(e) => setVolume(parseFloat(e.target.value))}
className="w-20"
/>
</>
) : (
<span className="text-[11px] text-text-secondary font-medium">
{duration > 0 && formatDuration(duration)}
</span>
)}
</div>
</div>
</div>

View File

@ -4,7 +4,6 @@ import { Play, Pause, Heart, MessageCircle, Clock, Share2 } from 'lucide-react'
import { supabase } from '@/lib/supabase'
import { useAuthStore } from '@/stores/auth'
import { usePlayerStore } from '@/stores/player'
import { getEmbedInfo } from '@/lib/embed'
import type { Podcast, Comment } from '@/types'
import { formatDuration, timeAgo } from '@/lib/utils'
import { Avatar } from '@/components/ui/Avatar'
@ -164,23 +163,6 @@ export function PodcastDetail() {
</div>
</div>
{/* Embedded player for external content */}
{(() => {
const embed = getEmbedInfo(podcast.audio_url)
if (!embed) return null
return (
<div className="rounded-2xl overflow-hidden shadow-md border border-border/50 aspect-video">
<iframe
src={embed.embedUrl.replace('autoplay=1', 'autoplay=0')}
className="w-full h-full"
allow="autoplay; encrypted-media; picture-in-picture"
allowFullScreen
title={podcast.title}
/>
</div>
)
})()}
{podcast.description && (
<div>
<h2 className="text-lg font-heading font-bold mb-2">Description</h2>

View File

@ -1,6 +1,26 @@
import { create } from 'zustand'
import type { Podcast } from '@/types'
import { isExternalUrl } from '@/lib/embed'
import { isExternalUrl, getEmbedInfo } from '@/lib/embed'
// Hidden iframe manager for external content
let hiddenIframe: HTMLIFrameElement | null = null
function destroyIframe() {
if (hiddenIframe) {
hiddenIframe.remove()
hiddenIframe = null
}
}
function createHiddenIframe(embedUrl: string) {
destroyIframe()
const iframe = document.createElement('iframe')
iframe.src = embedUrl
iframe.allow = 'autoplay; encrypted-media'
iframe.style.cssText = 'position:fixed;width:1px;height:1px;left:-10px;top:-10px;opacity:0;pointer-events:none;'
document.body.appendChild(iframe)
hiddenIframe = iframe
}
interface PlayerState {
current: Podcast | null
@ -33,8 +53,11 @@ export const usePlayerStore = create<PlayerState>((set, get) => ({
const { audio, current } = get()
const external = isExternalUrl(podcast.audio_url)
// Resume same podcast
if (current?.id === podcast.id) {
if (external) {
const embed = getEmbedInfo(podcast.audio_url)
if (embed) createHiddenIframe(embed.embedUrl)
set({ isPlaying: true })
return
}
@ -45,13 +68,17 @@ export const usePlayerStore = create<PlayerState>((set, get) => ({
}
}
// Stop previous
if (audio) {
audio.pause()
audio.removeAttribute('src')
}
destroyIframe()
// External URLs are handled by embed iframe, not HTMLAudioElement
// External: play via hidden iframe
if (external) {
const embed = getEmbedInfo(podcast.audio_url)
if (embed) createHiddenIframe(embed.embedUrl)
set({ audio: null, current: podcast, isPlaying: true, isExternal: true, progress: 0, duration: podcast.duration_seconds || 0 })
return
}
@ -74,7 +101,17 @@ export const usePlayerStore = create<PlayerState>((set, get) => ({
},
toggle: () => {
const { audio, isPlaying } = get()
const { audio, isPlaying, isExternal, current } = get()
if (isExternal) {
if (isPlaying) {
destroyIframe()
} else {
const embed = current ? getEmbedInfo(current.audio_url) : null
if (embed) createHiddenIframe(embed.embedUrl)
}
set({ isPlaying: !isPlaying })
return
}
if (!audio) return
if (isPlaying) {
audio.pause()
@ -85,6 +122,8 @@ export const usePlayerStore = create<PlayerState>((set, get) => ({
},
pause: () => {
const { isExternal } = get()
if (isExternal) destroyIframe()
get().audio?.pause()
set({ isPlaying: false })
},